01219245/iteration review - ประวัติรุ่นแก้ไข

Jittat: /* Code quality review */

2014-04-02T08:56:39Z

Code quality review

2014-04-02T07:24:47Z

Code quality review

2014-04-02T07:24:31Z

Code quality review

2014-04-02T07:17:23Z

Code quality review

2014-04-02T04:58:43Z

Project features

2014-04-02T04:56:16Z

Iteration review

2014-04-02T04:47:41Z

Iteration review

2014-04-02T04:42:24Z

2014-04-01T02:22:18Z

Push your code to your Git repository at Github/Bitbucket

2014-04-01T02:17:53Z

Push your code to your Git repository at Github/Bitbucket

←รุ่นแก้ไขก่อนหน้า		รุ่นแก้ไขเมื่อ 08:56, 2 เมษายน 2557
แถว 61:		แถว 61:
	** The reviewer should give review comments on the form. The reviewer should also talk with the code owner while giving the review comments.		** The reviewer should give review comments on the form. The reviewer should also talk with the code owner while giving the review comments.
	* Switch the role.		* Switch the role.
		+
		+	Also, put every javascript code into [http://jshint.com/ JSHint], and record important comments from it.
		+
		+	=== Self evaluation ===
		+
		+	Finally, give yourself a score, out of 10, for this iteration, considering:
		+
		+	* the progress that you have made
		+	* the quality of the game
		+	* the quality of the code
		+	* how much you learn from implementing this iteration

←รุ่นแก้ไขก่อนหน้า		รุ่นแก้ไขเมื่อ 07:24, 2 เมษายน 2557
แถว 60:		แถว 60:
	** Let the reviewer pick two interesting functions and look at the code of each function. The reviewer can ask questions to the code owner.		** Let the reviewer pick two interesting functions and look at the code of each function. The reviewer can ask questions to the code owner.
	** The reviewer should give review comments on the form. The reviewer should also talk with the code owner while giving the review comments.		** The reviewer should give review comments on the form. The reviewer should also talk with the code owner while giving the review comments.
		+	* Switch the role.

←รุ่นแก้ไขก่อนหน้า		รุ่นแก้ไขเมื่อ 07:24, 2 เมษายน 2557
แถว 51:		แถว 51:

	=== Code quality review ===		=== Code quality review ===
−	We will do a quick code review for "obvious" code quality standards. For this review, we will not work in a large group, but in a pair of 2 people. Use the following form: [http://theory.cpe.ku.ac.th/wiki/images/01219245-code-review-form1.pdf code-review-form1.pdf]	+	We will do a quick code review for "obvious" code quality standards. For this review, we will not work in a large group, but in a pair of 2 people.
		+
		+	* Form a pair with another student (not necessarily in the same group from the previous feature review).
		+	* One student starts as a reviewer.
		+	* Use the following form: [http://theory.cpe.ku.ac.th/wiki/images/01219245-code-review-form1.pdf code-review-form1.pdf] (I'll hand a paper form out in class)
		+	* Work on the code owner's machine:
		+	** Let the reviewer look at a few source files to give a review on the overall coding style.
		+	** Let the reviewer pick two interesting functions and look at the code of each function. The reviewer can ask questions to the code owner.
		+	** The reviewer should give review comments on the form. The reviewer should also talk with the code owner while giving the review comments.

←รุ่นแก้ไขก่อนหน้า		รุ่นแก้ไขเมื่อ 07:17, 2 เมษายน 2557
แถว 51:		แถว 51:

	=== Code quality review ===		=== Code quality review ===
		+	We will do a quick code review for "obvious" code quality standards. For this review, we will not work in a large group, but in a pair of 2 people. Use the following form: [http://theory.cpe.ku.ac.th/wiki/images/01219245-code-review-form1.pdf code-review-form1.pdf]

@@ แถว 40: / แถว 40: @@
   Good: ...........(list the things that you like about the project; what are the things you think that the owner has done well in this iteration).......................
   Try: ...........(list the things that can be improved, give suggestions on what the owner should try in the next iteration).............
 === Code quality review ===

@@ แถว 26: / แถว 26: @@
 == Iteration review ==
 We will review the project features and the quality of the code.
 === Project features ===
-In your Trello board, create a new card called '''Iteration 1 comments''' in the '''Course''' list.  Invite your friends in your group to your board.  (You can remove them later after the review.)
+In your Trello board, create a new card called '''Iteration 1 comments''' in the '''Course''' list.  Invite your friends in your group to your board.  (You can remove them later after the review.)  You friend will put comments related to your project features and project quality (not related to the code) there.
 === Code quality review ===

←รุ่นแก้ไขก่อนหน้า		รุ่นแก้ไขเมื่อ 04:47, 2 เมษายน 2557
แถว 26:		แถว 26:

	== Iteration review ==		== Iteration review ==
		+	We will review the project features and the quality of the code.
		+
		+	=== Project features ===
		+	In your Trello board, create a new card called '''Iteration 1 comments''' in the '''Course''' list. Invite your friends in your group to your board. (You can remove them later after the review.)
		+
		+	=== Code quality review ===

←รุ่นแก้ไขก่อนหน้า		รุ่นแก้ไขเมื่อ 04:42, 2 เมษายน 2557
แถว 24:		แถว 24:

	'''If you change your Git repository,''' don't forget to update the link on your Trello board.		'''If you change your Git repository,''' don't forget to update the link on your Trello board.
		+
		+	== Iteration review ==

←รุ่นแก้ไขก่อนหน้า		รุ่นแก้ไขเมื่อ 02:22, 1 เมษายน 2557
แถว 22:		แถว 22:

	Your friends will get your software by cloning your code from your repository. So don't forget to push your code there. If you have big media files (e.g., some sounds/images which are larger than, maybe, ten megabytes), you should avoid pushing those files to the repository, though. In this case, you can discuss with me how to host these files.		Your friends will get your software by cloning your code from your repository. So don't forget to push your code there. If you have big media files (e.g., some sounds/images which are larger than, maybe, ten megabytes), you should avoid pushing those files to the repository, though. In this case, you can discuss with me how to host these files.
		+
		+	'''If you change your Git repository,''' don't forget to update the link on your Trello board.

←รุ่นแก้ไขก่อนหน้า		รุ่นแก้ไขเมื่อ 02:17, 1 เมษายน 2557
แถว 20:		แถว 20:

	=== Push your code to your Git repository at Github/Bitbucket ===		=== Push your code to your Git repository at Github/Bitbucket ===
		+
		+	Your friends will get your software by cloning your code from your repository. So don't forget to push your code there. If you have big media files (e.g., some sounds/images which are larger than, maybe, ten megabytes), you should avoid pushing those files to the repository, though. In this case, you can discuss with me how to host these files.